Escape SLA status text for compatibility with notification services s… #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 98.99% 99.09% +0.09%
==========================================
Files 85 83 -2
Lines 5844 5825 -19
==========================================
- Hits 5785 5772 -13
+ Misses 44 40 -4
+ Partials 15 13 -2 ☔ View full report in Codecov by Sentry. |
suchen-sci
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #468 , when sending SLA notifications, the Lark notification service will generate the following response:
code [9499] - msg [Bad Request])This is because the SLAStatusText content contains
\twhich is not compatible with Lark.This PR is a quick fix, the best way is to define content struct as demonstrated in PR #469, which needs a complete refactor and testing work.