Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint label to metrics #382

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

Zhang21
Copy link
Contributor

@Zhang21 Zhang21 commented Jul 11, 2023

Add endpoint label to metrics that can represent an address of each ProbeKind(http/tcp/...)。

Detail Issue: #368

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1053595) 99.68% compared to head (38cbd76) 99.68%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          83       83           
  Lines        5688     5722   +34     
=======================================
+ Hits         5670     5704   +34     
  Misses         12       12           
  Partials        6        6           
Impacted Files Coverage Δ
probe/base/base.go 100.00% <100.00%> (ø)
probe/base/metrics.go 100.00% <100.00%> (ø)
probe/http/http.go 100.00% <100.00%> (ø)
probe/http/metrics.go 100.00% <100.00%> (ø)
probe/ping/metrics.go 100.00% <100.00%> (ø)
probe/ping/ping.go 100.00% <100.00%> (ø)
probe/shell/metrics.go 100.00% <100.00%> (ø)
probe/shell/shell.go 100.00% <100.00%> (ø)
probe/ssh/metrics.go 100.00% <100.00%> (ø)
probe/ssh/ssh.go 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@localvar localvar merged commit f9dea19 into megaease:main Jul 17, 2023
@Zhang21 Zhang21 deleted the feat-metrics-labels branch July 27, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants