Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minutely sla reports #236

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Minutely sla reports #236

merged 6 commits into from
Oct 20, 2022

Conversation

proditis
Copy link
Collaborator

@proditis proditis commented Oct 19, 2022 •
edited
Loading

This PR includes the following:

  • Add minutely SLA schedule interval
  • Add missing code for "hourly" SLA schedule interval
  • Minor updates to wording of the messages
  • Remove a duplicate log.Infof

@proditis proditis requested a review from haoel October 19, 2022 11:20
haoel
haoel approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@haoel haoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR! just a couple of minor comments.

cmd/easeprobe/report.go Outdated Show resolved Hide resolved
cmd/easeprobe/report.go Outdated Show resolved Hide resolved
@haoel haoel mentioned this pull request Oct 19, 2022
Closed
@haoel haoel merged commit c170321 into megaease:main Oct 20, 2022
@haoel haoel mentioned this pull request Oct 20, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoel haoel haoel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proditis @haoel