Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fixing: http probe report the unsupported document type #235

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Oct 17, 2022

If http probe didn't configure the eval/doc, EaseProbe would report the error - Unsupported document type: unsupported

This bug only can be reproduced after PR #192

here is the fix - check if the eval configuration is not configured, then skip the eval configration.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 99.64% // Head: 99.70% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (8d3439c) compared to base (1821c1e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   99.64%   99.70%   +0.05%     
==========================================
  Files          72       70       -2     
  Lines        5084     5069      -15     
==========================================
- Hits         5066     5054      -12     
+ Misses         12       11       -1     
+ Partials        6        4       -2     
Impacted Files Coverage Δ
eval/eval.go 98.02% <100.00%> (-1.98%) ⬇️
daemon/daemon_windows.go
notify/log/log_windows.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@samanhappy samanhappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this makes the error message go away 👍

@haoel haoel merged commit 6983ee5 into megaease:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants