Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support the failure/success threshold for probe #233

Merged
merged 6 commits into from
Oct 19, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Oct 14, 2022

This PR supports the failure/success threshold features - we can configure the number of continuously failed/successful probes to determine whether the endpoint status is DOWN or UP.

for example:

probe:
    failure: 2 # number of consecutive failed probes needed to determine the status down, default: 1
    success: 1 # number of consecutive successful probes needed to determine the status down, default: 1

close #230

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Base: 99.64% // Head: 99.65% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fc6d6b8) compared to base (26c1c31).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   99.64%   99.65%           
=======================================
  Files          72       73    +1     
  Lines        5083     5164   +81     
=======================================
+ Hits         5065     5146   +81     
  Misses         12       12           
  Partials        6        6           
Impacted Files Coverage Δ
conf/conf.go 96.73% <ø> (ø)
global/global.go 100.00% <ø> (ø)
global/probe.go 100.00% <100.00%> (ø)
probe/base/base.go 100.00% <100.00%> (ø)
probe/result.go 100.00% <100.00%> (ø)
probe/status.go 100.00% <100.00%> (ø)
probe/status_counter.go 100.00% <100.00%> (ø)
report/result.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/Manual.md Outdated Show resolved Hide resolved
docs/Manual.md Outdated Show resolved Hide resolved
global/probe.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change of continuously to consecutive.
Need to test run some cases still.

docs/Manual.md Outdated Show resolved Hide resolved
docs/Manual.md Outdated Show resolved Hide resolved
resources/config.yaml Outdated Show resolved Hide resolved
resources/config.yaml Outdated Show resolved Hide resolved
resources/config.yaml Outdated Show resolved Hide resolved
docs/Manual.md Outdated Show resolved Hide resolved
Co-authored-by: Pantelis Roditis <[email protected]>
@haoel haoel merged commit 240c658 into megaease:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failure/success threshold before sending notifications
6 participants