Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the README.md #210

Merged
merged 9 commits into from
Sep 4, 2022
Merged

Refactoring the README.md #210

merged 9 commits into from
Sep 4, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Sep 2, 2022

  • Move the most content to the docs/Manual.md
  • Add the HTTP XPath/RegExp expression evaluation in Manual.md
  • Add a configuration template - resources/config.yaml

@haoel haoel requested a review from proditis September 2, 2022 07:24
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Base: 99.71% // Head: 99.71% // No change to project coverage 👍

Coverage data is based on head (f17af58) compared to base (76c166c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          70       70           
  Lines        4975     4975           
=======================================
  Hits         4961     4961           
  Misses          9        9           
  Partials        5        5           
Impacted Files Coverage Δ
notify/sms/nexmo/nexmo.go 100.00% <100.00%> (ø)
notify/sms/twilio/twilio.go 100.00% <100.00%> (ø)
notify/sms/yunpian/yunpian.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haoel haoel merged commit 0108e6f into megaease:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants