-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support MySQL/Redis/MongoDB/PostgreSQL/Zookeeper Native Client to check the data #171
Conversation
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 93.43% 93.89% +0.46%
==========================================
Files 46 46
Lines 3411 3636 +225
==========================================
+ Hits 3187 3414 +227
+ Misses 157 155 -2
Partials 67 67
Continue to review full report at Codecov.
|
Question: Do we need to support probing all nodes of a Redis cluster with one configuration? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM not tested yet
Co-authored-by: Pantelis Roditis <[email protected]>
At this moment, we don't have a plan to do this, we only can configure a cluster by individual configuration. To introduce the cluster concept is good for configuration, but we have to separate the cluster into individual prober, and name every prober a unique name, and people might need a cluster-wide healthy status or SLA, this would bring complexity to the current design. So, I'd like to be a businessman here, I want to see how many benefits we can get from this requirement. ;-) |
LGTM! |
Redis
MySQL
MongoDB
PostgreSQL
Zookeeper