Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Equally distributing start the probers. #157

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Jul 2, 2022

To avoid all probers starting at the same time, each prober delays the start time and all of them have an equal distribution.

This enhancement would improve the performance of the EaseProbe.

@haoel haoel requested review from proditis and zhao-kun July 2, 2022 06:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #157 (abc93fd) into main (e6a7914) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          45       45           
  Lines        3197     3197           
=======================================
  Hits         2947     2947           
  Misses        185      185           
  Partials       65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a7914...abc93fd. Read the comment docs.

@haoel haoel changed the title Enhancement: Randomly start the probers Enhancement: Equally distributing start the probers. Jul 2, 2022
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i havent got a chance to test it yet.

@zhao-kun zhao-kun merged commit b420236 into megaease:main Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants