Sourcery Starbot ⭐ refactored meetps/pytorch-semseg #264

SourceryAI · 2023-02-07T01:11:00Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch https://github.com/sourcery-ai-bot/pytorch-semseg master
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI

Due to GitHub API limits, only the first 60 comments can be shown.

SourceryAI · 2023-02-07T01:11:02Z

test.py

-    print("Read Input Image from : {}".format(args.img_path))
+    print(f"Read Input Image from : {args.img_path}")


Function test refactored with the following changes:

Replace call to format with f-string [×3] (use-fstring-for-formatting)

Use f-string instead of string concatenation (use-fstring-for-concatenation)

SourceryAI · 2023-02-07T01:11:02Z

train.py

-    logger.info("Using optimizer {}".format(optimizer))
+    logger.info(f"Using optimizer {optimizer}")

    scheduler = get_scheduler(optimizer, cfg["training"]["lr_schedule"])

    loss_fn = get_loss_function(cfg)
-    logger.info("Using loss {}".format(loss_fn))
+    logger.info(f"Using loss {loss_fn}")

    start_iter = 0
    if cfg["training"]["resume"] is not None:
        if os.path.isfile(cfg["training"]["resume"]):
            logger.info(
-                "Loading model and optimizer from checkpoint '{}'".format(cfg["training"]["resume"])
+                f"""Loading model and optimizer from checkpoint '{cfg["training"]["resume"]}'"""


Function train refactored with the following changes:

Replace call to format with f-string [×10] (use-fstring-for-formatting)

Use previously assigned local variable (use-assigned-variable)

SourceryAI · 2023-02-07T01:11:02Z

train.py

-    print("RUNDIR: {}".format(logdir))
+    print(f"RUNDIR: {logdir}")


Lines 223-223 refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

SourceryAI · 2023-02-07T01:11:03Z

ptsemseg/metrics.py

-        hist = np.bincount(
-            n_class * label_true[mask].astype(int) + label_pred[mask], minlength=n_class ** 2
+        return np.bincount(
+            n_class * label_true[mask].astype(int) + label_pred[mask],
+            minlength=n_class**2,
        ).reshape(n_class, n_class)
-        return hist


Function runningScore._fast_hist refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

SourceryAI · 2023-02-07T01:11:03Z

ptsemseg/utils.py

-    file_path = os.path.join(logdir, "run_{}.log".format(ts))
+    file_path = os.path.join(logdir, f"run_{ts}.log")


Function get_logger refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

SourceryAI · 2023-02-07T01:11:05Z

ptsemseg/loader/cityscapes_loader.py

-            raise Exception("No files for split=[%s] found in %s" % (split, self.images_base))
+            raise Exception(f"No files for split=[{split}] found in {self.images_base}")


Function cityscapesLoader.__init__ refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

SourceryAI · 2023-02-07T01:11:05Z

ptsemseg/loader/cityscapes_loader.py

-            os.path.basename(img_path)[:-15] + "gtFine_labelIds.png",
+            f"{os.path.basename(img_path)[:-15]}gtFine_labelIds.png",


Function cityscapesLoader.__getitem__ refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

SourceryAI · 2023-02-07T01:11:06Z

ptsemseg/loader/cityscapes_loader.py

-        for l in range(0, self.n_classes):
+        for l in range(self.n_classes):


Function cityscapesLoader.decode_segmap refactored with the following changes:

Replace range(0, x) with range(x) (remove-zero-from-range)

SourceryAI · 2023-02-07T01:11:06Z

ptsemseg/loader/mapillary_vistas_loader.py

-            raise Exception("No files for split=[%s] found in %s" % (split, self.images_base))
+            raise Exception(f"No files for split=[{split}] found in {self.images_base}")


Function mapillaryVistasLoader.__init__ refactored with the following changes:

Replace interpolated string formatting with f-string (replace-interpolation-with-fstring)

SourceryAI · 2023-02-07T01:11:06Z

ptsemseg/loader/mapillary_vistas_loader.py

-        print("There are {} labels in the config file".format(len(labels)))
+        print(f"There are {len(labels)} labels in the config file")


Function mapillaryVistasLoader.parse_config refactored with the following changes:

Replace call to format with f-string (use-fstring-for-formatting)

hjhjb · 2023-02-07T01:11:26Z

我已收到，谢谢

'Refactored by Sourcery'

540164b

SourceryAI commented Feb 7, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery Starbot ⭐ refactored meetps/pytorch-semseg #264

Sourcery Starbot ⭐ refactored meetps/pytorch-semseg #264

SourceryAI commented Feb 7, 2023

SourceryAI left a comment

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

SourceryAI Feb 7, 2023

hjhjb commented Feb 7, 2023 via email

		print("Read Input Image from : {}".format(args.img_path))
		print(f"Read Input Image from : {args.img_path}")

		print("RUNDIR: {}".format(logdir))
		print(f"RUNDIR: {logdir}")

		file_path = os.path.join(logdir, "run_{}.log".format(ts))
		file_path = os.path.join(logdir, f"run_{ts}.log")

		raise Exception("No files for split=[%s] found in %s" % (split, self.images_base))
		raise Exception(f"No files for split=[{split}] found in {self.images_base}")

		os.path.basename(img_path)[:-15] + "gtFine_labelIds.png",
		f"{os.path.basename(img_path)[:-15]}gtFine_labelIds.png",

		for l in range(0, self.n_classes):
		for l in range(self.n_classes):

		print("There are {} labels in the config file".format(len(labels)))
		print(f"There are {len(labels)} labels in the config file")

Sourcery Starbot ⭐ refactored meetps/pytorch-semseg #264

Are you sure you want to change the base?

Sourcery Starbot ⭐ refactored meetps/pytorch-semseg #264

Conversation

SourceryAI commented Feb 7, 2023

SourceryAI left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjhjb commented Feb 7, 2023 via email