Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut fixed from ctrl+10 to ctrl+0 #1091

Closed
wants to merge 1 commit into from
Closed

Shortcut fixed from ctrl+10 to ctrl+0 #1091

wants to merge 1 commit into from

Conversation

bimbo1989
Copy link

Description

Ctrl+10 can't obviously be a legit shortcut, so changed to ctrl+0

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [X ] My code follows the code style of this project (run $ yarn lint).

@adlk adlk changed the base branch from master to develop November 16, 2018 12:42
@adlk
Copy link
Contributor

adlk commented Nov 16, 2018

Ctrl/Cmd+0 is used to reset zoom. Also, I can't reproduce the issue of having Ctrl+10 as a keyboard shortcut. When does this happen?

@bimbo1989
Copy link
Author

Happens to me on Windows when adding 10 services, you'll se in the status bar dropdown menu a CTRL+10 suggestion

@adlk
Copy link
Contributor

adlk commented Nov 16, 2018 •
edited
Loading

status bar dropdown

do you mean the app menu under "Services"

@adlk adlk closed this in 0db7c12 Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
more information required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bimbo1989 @adlk