Merge pull request #25 from meemalabs/fix-test-cases

fix: test cases
meemalabs · Aug 17, 2021 · a1b27c1 · a1b27c1
2 parents 5c4f661 + 60c41c9
commit a1b27c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Converters/MediaConvert.php b/src/Converters/MediaConvert.php
@@ -117,7 +117,7 @@ public function withThumbnails(int $framerateNumerator, int $framerateDenominato
      */
     public function saveTo(string $s3Path, $s3bucket = null): MediaConvert
     {
-        $destination = 's3://'.($s3bucket ?? config('filesystems.disks.s3.bucket')).$s3Path;
+        $destination = 's3://'.($s3bucket ?? config('filesystems.disks.s3.bucket')).'/'.$s3Path;
 
         $this->jobSettings['OutputGroups'][0]['OutputGroupSettings']['FileGroupSettings']['Destination'] = $destination.'/thumbnails/';
         $this->jobSettings['OutputGroups'][1]['OutputGroupSettings']['FileGroupSettings']['Destination'] = $destination.'/mp4/';

diff --git a/tests/MediaConverterTest.php b/tests/MediaConverterTest.php
@@ -59,7 +59,7 @@
         ->withThumbnails(1, 2, 3, 100)
         ->saveTo($outputName, $bucket);
 
-    $destination = 's3://test-bucket';
+    $destination = 's3://test-bucket'.'/'.$outputName;
 
     $this->assertEquals($converter->jobSettings['OutputGroups'][0]['OutputGroupSettings']['FileGroupSettings']['Destination'], $destination.'/thumbnails/');
     $this->assertEquals($converter->jobSettings['OutputGroups'][1]['OutputGroupSettings']['FileGroupSettings']['Destination'], $destination.'/mp4/');