CI: fail build if unstaged changes #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spowelljr
force-pushed
the
preventMergingIfChanges
branch
from
c986aae
to
d5a1ec0
Compare
medyagh
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for unstaged changes after running
npm run all, fail the build if it does.This prevents a user from trying to merge a
dist/index.jsbuilt with malicious code that's not included in their PR.This will also prevent the more common issue that users may forget to build before pushing their changes up.
Removed minifying
dist/index.jsas minifying has a guaranteed chance of causing merge conflicts.Also replaced
npm installwithnpm cias that should be used instead in CI.