Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication, types): Create authentication entities and services #5979

Merged
merged 23 commits into from
Jan 8, 2024
Merged

feat(authentication, types): Create authentication entities and services #5979

merged 23 commits into from
Jan 8, 2024

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Jan 2, 2024 •
edited
Loading

What

  • Add authentication module models
    • AuthProvider
    • AuthUser
  • Add respective services and module methods

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 8:14am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 8:14am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 8:14am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f6e62a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pKorsholm pKorsholm changed the title create authentication entities feat(authentication, types): Create authentication entities and services Jan 2, 2024
@pKorsholm pKorsholm marked this pull request as ready for review January 2, 2024 10:36
@pKorsholm pKorsholm requested a review from a team as a code owner January 2, 2024 10:36
@pKorsholm pKorsholm requested a review from adrien2p January 2, 2024 10:37
adrien2p
adrien2p reviewed Jan 2, 2024
View reviewed changes
packages/authentication/integration-tests/__fixtures__/auth-provider/index.ts Outdated Show resolved Hide resolved
packages/authentication/integration-tests/__fixtures__/auth-user/index.ts Outdated Show resolved Hide resolved
packages/authentication/src/models/auth-user.ts Outdated Show resolved Hide resolved
packages/authentication/src/models/auth-user.ts Outdated Show resolved Hide resolved
packages/authentication/src/repositories/auth-provider.ts Outdated Show resolved Hide resolved
packages/authentication/src/services/authentication-module.ts Outdated Show resolved Hide resolved
packages/authentication/src/services/authentication-module.ts Outdated Show resolved Hide resolved
packages/authentication/src/services/authentication-module.ts Outdated Show resolved Hide resolved
packages/authentication/src/services/authentication-module.ts Outdated Show resolved Hide resolved
packages/pricing/package.json Outdated Show resolved Hide resolved
@pKorsholm pKorsholm requested a review from adrien2p January 3, 2024 09:02
olivermrbl
olivermrbl reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiice work @pKorsholm !

packages/types/src/authentication/common/authenticated-user.ts Outdated Show resolved Hide resolved
packages/types/src/authentication/common/authenticated-user.ts Outdated Show resolved Hide resolved
packages/authentication/src/types/services/auth-user.ts Outdated Show resolved Hide resolved
olivermrbl
olivermrbl requested changes Jan 5, 2024
View reviewed changes
packages/authentication/src/models/auth-user.ts Outdated
} from "@mikro-orm/core"
import AuthProvider from "./auth-provider"

type OptionalFields = "password_hash" | "app_metadata" | "user_metadata"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type OptionalFields = "password_hash" | "app_metadata" | "user_metadata"
type OptionalFields = "provider_metadata" | "app_metadata" | "user_metadata"

packages/authentication/src/types/repositories/auth-user.ts Outdated
import { AuthUser } from "@models"

export type CreateAuthUserDTO = {
email?: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Wasn't email moved to provider_metadata too?

@pKorsholm pKorsholm requested a review from olivermrbl January 8, 2024 08:04
@pKorsholm pKorsholm merged commit 479a8b8 into develop Jan 8, 2024
15 checks passed
@TheValkDokk TheValkDokk mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p Awaiting requested review from adrien2p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pKorsholm @adrien2p @olivermrbl