Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Deleted default sales channel should be prevented #10193

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Nov 21, 2024

FIXES CMRC-722

What

  • It should not be allowed to delete a default sales channel
  • The admin does not allow to delete a sales channel use as the default for the store

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 1:21pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 1:21pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 1:21pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 1:21pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 1:21pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 1:21pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 1:21pm

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: c672af2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/core-flows Patch
@medusajs/types Patch
@medusajs/dashboard Patch
integration-tests-http Patch
@medusajs/admin-bundler Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p marked this pull request as ready for review November 22, 2024 15:57
@adrien2p adrien2p requested a review from a team as a code owner November 22, 2024 15:57
@adrien2p
Copy link
Member Author

Add tooltip once this pr is merged

Comment on lines +2311 to +2313
"tooltip": {
"cannotDeleteDefault": "Cannot delete default sales channel"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasperkristensen could you validate that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant