-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ptBR (Brazilian Portuguese) in translations #10188
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8981b97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@DanSilva41 is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There are just minor suggestions.
Thanks for the PR @DanSilva41.
Thanks for the notes and review, @carlos-r-l-rodrigues. It's done! |
packages/admin/dashboard/src/i18n/translations/__tests__/validate-translations.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @DanSilva41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some new keys were added, so would be good to get them in:
Validation failed for ptBR.json:
Missing required key: "transfer" at orders
Missing required key: "from" at orders.activity
Missing required key: "to" at orders.activity
Missing required key: "transfer" at orders.activity.events
This PR currently has a merge conflict. Please resolve this and then re-add the |
Hi, @kasperkristensen. |
Changelog