dcm4che(issue #159) #164 #3
Conversation
Prevent read of tag beyond specified length. Toolkit detect child tags with length > the containing item length and stop trying to parse the sequence item.
There was a problem hiding this comment.
This doesn't look like the same fix that was made for dcm4che issue dcm4che#159. That fix will actually attempt to determine if the tags are encoded with explicit VR and then parse them. This looks like it will just skip the tags entirely.
Is there a reason the existing fix couldn't be cherry-picked? When I looked at it, it didn't seem like there would be many conflicts.
|
It looks like there are no changes to the readAttributes method - do we need the changes from issue#159 pulled into that method as well? |
Yeah, looks like that just removes the decodeUNWithIVRLE stuff which is no longer relevant. |
Prevent read of tag beyond specified length.
Toolkit detect child tags with length > the containing item length and
stop trying to parse the sequence item.