This repository has been archived by the owner on Jan 28, 2019. It is now read-only.
refactored outgoing deny list config handling. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 11, 2015 19:13
Outgoing deny list will now be applied to schedules and responses generated on reports. So instead of seeing `scheduled` or `pending` state on a message you will see `denied`. Moved `isOutgoingAllowed`, `_isMessageFromGateway` and related tests into utils library so schedule creation and report validation and response messages can make use of it. Calling `messages.addMessage` or `uitls.addScheduledMessage` now transparently checks the outgoing deny list and assigns a `denied` state when appropriate. I removed some odd logic in `addScheduledMessage` because it's not used or documented anywhere and is error prone. There was a check for `doc.muted` field when creating a scheduled message. I looked through the code and fairly certain this property is not set or used by anything.
mandric
added a commit
that referenced
this pull request
Nov 11, 2015
refactored outgoing deny list config handling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: medic/cht-core#750
Outgoing deny list will now be applied to schedules and responses
generated on reports. So instead of seeing
scheduledorpendingstate on a message you will see
denied.Moved
isOutgoingAllowed,_isMessageFromGatewayand related testsinto utils library so schedule creation and report validation and
response messages can make use of it.
Calling
messages.addMessageoruitls.addScheduledMessagenowtransparently checks the outgoing deny list and assigns a
deniedstatewhen appropriate.
I removed some odd logic in
addScheduledMessagebecause it's not usedor documented anywhere and is error prone. There was a check for
doc.mutedfield when creating a scheduled message. I looked throughthe code and fairly certain this property is not set or used by
anything.