-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment doc after helm chart changes #218
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - thanks Paul!
I was able to deploy over MoH UG and all worked great.
I have one question about removing deploy
branch use, but approving otherwise to unblock as it all works as expected.
2. Commit a values YAML file in [values folder](https://github.com/medic/cht-user-management/blob/main/scripts/deploy/values/) in `main` branch | ||
3. Switch to the `deploy` branch and ensure the same values file from the prior step is in the [values folder](https://github.com/medic/cht-user-management/blob/deploy/scripts/deploy/values/) in `deploy` branch | ||
4. Edit the version in the `tag:` as the version you want deploy in the `helm` command below. Ensure this version in the `tag:` is commmited to `deploy` branch | ||
5. run either `helm install...` or `helm deploy...` per the full commands below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we wanted to use the deploy
branch so that we didn't need to do a whole PR every time we wanted to push. I also think this might result in extra images being built and pushed to ECR? Slack thread:
For deployments, I've been pushing to this deploy branch which is probably lazy but I also don't want to make a new PR every time I push. And when I merge it, publishes duplicate images.
This changes that - but maybe it's OK because we want to not use deploy
branch and over all are changing things less often?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we wanted to use the deploy branch so that we didn't need to do a whole PR every time we wanted to push....
Oh yes thats right, I got it and I think we still don't want to make a whole PR for every push, neither duplicated images published... :)
So maybe I should bring back the deploy
branch use ? I am not sure I know the best thing to do here 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say let's revisit it in the #cht-user-management
and we can discuss async.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Closes #217
Key points:
helm repo update
).helm upgrade
to work, delete existing helm values before reinstalling.