Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename compose project from pipeline to cht-sync #178

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mrjones-plip
Copy link
Contributor

@mrjones-plip mrjones-plip commented Oct 25, 2024

Description

Our docker compose project is named pipeline which we don't reference anymore. This also causes containers to be named pipeline-pgadmin etc. which folks may not know is actually cht-sync related:

docker ps --format "table {{.Status}}\t{{.Names}}"        
STATUS                         NAMES
Restarting (1) 4 seconds ago   pipeline-couch2pg-1
Up 21 seconds                  pipeline-pgadmin-1
Up 21 seconds                  pipeline-dbt-1
Up 19 seconds                  pipeline-postgres-1

I think we should comment out the .env project name and add a sane default to the main compose file.

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@mrjones-plip mrjones-plip changed the title Rename compose project from pipeline to cht-sync chore(na): Rename compose project from pipeline to cht-sync Oct 25, 2024
@mrjones-plip mrjones-plip changed the title chore(na): Rename compose project from pipeline to cht-sync chore(na): rename compose project from pipeline to cht-sync Oct 25, 2024
Copy link
Contributor

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mrjones-plip mrjones-plip merged commit 43997a8 into main Oct 28, 2024
6 of 9 checks passed
@mrjones-plip mrjones-plip deleted the mrjones-plip-patch-1 branch October 28, 2024 12:46
@andrablaj andrablaj changed the title chore(na): rename compose project from pipeline to cht-sync chore: rename compose project from pipeline to cht-sync Oct 28, 2024
@medic-ci
Copy link

🎉 This PR is included in version 1.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants