fail on bad builds in CI earlier #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nomulex - Ready for review! |
|
FYI @abbyad |
|
oh @alixemden - let me know if you can't override @MaxDiz being a reviewer, given he's out on paternal leave. |
|
I just removed @MaxDiz as reviewer. |
|
LGTM. I am feeling like a prophet this morning. I remember mentioning this here. ;) |
|
@nomulex - Ohhh! I think don't think I fully understood your point earlier! Well, next time we'll be sure to listen to you ;) Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build adds a call to
hugo buildthat exposes bad builds earlier on in the CI process. We had an issue where a broken build was pushed and CI broke at theAll Branches - Run Muffet link checkerstop in a very non obvious way with:This PR fixes that by explicitly running
hugoearly the CI process and it's called "All Branches - Test For Broken Builds in Hugo" so editors will know why their branch isn't passing CI when it breaks.see #299