-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct links with incorrect #named_anchor #260
Comments
mrjones-plip
pushed a commit
that referenced
this issue
Jul 31, 2020
Merged
mrjones-plip
pushed a commit
that referenced
this issue
Jul 31, 2020
mrjones-plip
pushed a commit
that referenced
this issue
Jul 31, 2020
mrjones-plip
pushed a commit
that referenced
this issue
Jul 31, 2020
mrjones-plip
pushed a commit
that referenced
this issue
Jul 31, 2020
mrjones-plip
pushed a commit
that referenced
this issue
Jul 31, 2020
mrjones-plip
pushed a commit
that referenced
this issue
Jul 31, 2020
mrjones-plip
pushed a commit
that referenced
this issue
Aug 18, 2020
mrjones-plip
pushed a commit
that referenced
this issue
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
While working on #259 it was discovered that our docs have a lot links that are valid, but have an invalid named anchor in the URL (the part after the
#
).While not critical to fix, we should either decide to keep these up to date (and thus break the build if they're bad) or decide to do something less. Less might be checking them less frequently? I'm open to ideas!
Results were found with:
Sample Result
http://YOUR_LOCAL_HUGO_INSTANCE/SPECIFIC/PAGE
Results - Special Fixes
http://localhost:1313/contribute/docs/style-guide/
id#images-1 not found https://www.markdownguide.org/basic-syntax/#images-1NB - added with JS in browser, not detectable bymuffet
, is validid#tables not found https://www.markdownguide.org/extended-syntax/#tablesNB - added with JS in browser, not detectable bymuffet
, is validhttp://localhost:1313/apps/reference/contact-page/
id#/guide/06_variable-replacement not found https://angular-translate.github.io/docs/#/guide/06_variable-replacementNB - deep link for angular-translate's SPA docs site, not detectable bymuffet
, is validid#fields not found http://localhost:1313/apps/reference/contact-page/#fieldsfixedhttp://localhost:1313/core/overview/translations/
id#/guide/05_using-translate-directive not found http://angular-translate.github.io/docs/#/guide/05_using-translate-directiveNB - deep link for angular-translate's SPA docs site, not detectable bymuffet
, is validhttp://localhost:1313/apps/guides/messaging/africas-talking/
id#39;s Talking SMS Aggregator'&labels=enhancement&body=Page:+/apps/guides/messaging/africas-talking/fixed - NB - this will likely come back to haunt us asVersion:+2020-06-05 21:05:09 -0400 -0400
--- not found https://github.com/medic/cht-docs/issues/new?title=Improve+%27Africa's%20Talking%20SMS%20Aggregator%27&labels=enhancement&body=Page:+/apps/guides/messaging/africas-talking/%0AVersion:+2020-06-05%2021:05:09%20-0400%20-0400%0A---
'
is the value of for URL encoded apostrophe whichmuffet
interprets as an id. Using a’
instead of a'
for now.http://localhost:1313/apps/guides/messaging/message-loops/
id#issuecomment-146254467 not found Do not autorespond to numbers on Blacklist cht-core#750 (comment)fixed NB - while the deep link to the exact fix was handy, you have to read the whole ticket for context any way, so a top level link is fine methinksResults - Normal Fixes
http://localhost:1313/apps/features/integrations/dhis2/
id#get-apiv2exportdhis not found https://github.com/medic/cht-core/tree/master/api#get-apiv2exportdhisfixedhttp://localhost:1313/apps/reference/forms/app/
id#care-guides not found http://localhost:1313/apps/reference/forms/contact/#care-guidesfixedid#icons not found http://localhost:1313/apps/reference/forms/app/#iconsfixedid#localization not found http://localhost:1313/apps/reference/forms/app/#localizationfixedhttp://localhost:1313/apps/guides/database/rdbms-from-windows/
id#tab-top not found https://stackoverflow.com/questions/2224066/how-to-convert-ssh-keypairs-generated-using-puttygenwindows-into-key-pairs-use?answertab=votes#tab-topfixedhttp://localhost:1313/apps/guides/hosting/ec2-setup-guide/
id#service-management-scripts not found https://github.com/medic/medic-os#service-management-scriptsfixedhttp://localhost:1313/apps/guides/hosting/self-hosting/
id#service-management-scripts not found https://github.com/medic/medic-os#service-management-scriptsfixedhttp://localhost:1313/contribute/docs/workflow/
id#installing-hugo not found https://github.com/medic/cht-docs/blob/master/README.md#installing-hugofixedhttp://localhost:1313/apps/concepts/prerequisites/
id#installation not found https://github.com/medic/medic-conf/blob/master/README.md#installationfixedhttp://localhost:1313/apps/guides/debugging/replicating-production-data-locally/
id#what-it-does not found https://github.com/pouchdb/add-cors-to-couchdb#what-it-doesfixedhttp://localhost:1313/core/overview/data-flows-for-analytics/
id#installation-steps-if-applicable not found https://github.com/medic/medic-couch2pg#installation-steps-if-applicablefixedhttp://localhost:1313/core/guides/releasing/
id#releasing not found https://github.com/medic/medic-conf/#releasingfixedhttp://localhost:1313/apps/reference/app-settings/outbound/
id#post-apiv2records not found https://github.com/medic/medic/tree/master/api#post-apiv2recordsfixedid#usage not found https://github.com/mariocasciaro/object-path#usagefixedhttp://localhost:1313/apps/guides/forms/app-form-sms/
id#compact-record-representation-(for-sms) not found https://opendatakit.github.io/xforms-spec/#compact-record-representation-(for-sms)fixedhttp://localhost:1313/apps/guides/messaging/sms-states/
id#content not found https://github.com/medic/medic-gateway#contentfixedhttp://localhost:1313/apps/guides/forms/multimedia/
id#Browser_compatibility not found https://developer.mozilla.org/en-US/docs/Web/HTML/Supported_media_formats#Browser_compatibilityfixedhttp://localhost:1313/apps/guides/data/csv-to-docs/
id#oauth2-client not found https://github.com/googleapis/google-api-nodejs-client#oauth2-clientfixedhttp://localhost:1313/apps/guides/debugging/obtaining-logs/
id#medic-logs not found https://github.com/medic/medic-conf#medic-logsfixedThe text was updated successfully, but these errors were encountered: