Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tag 'v1.2.5-internal' #54

Merged
merged 7 commits into from
Sep 22, 2020
Merged

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Sep 22, 2020

In prior to upgrade Cosmos SDK to the latest, I would like to sync the master with the v1.2.5-internal which is deployed for mainnet and testnet.

It seems all commits in the v1.2.5-internal are for updating go.mod. (tendermint and medibloc/cosmos-sdk)

image

@youngjoon-lee
Copy link
Contributor Author

youngjoon-lee commented Sep 22, 2020

It seems the cosmos/cosmos-sdk which is used by medibloc/cosmos-sdk has a bug.
When running panacead ..., I got an error when --trust-node is false, but I couldn't specify it due to:

(⎈ |N/A:N/A)~/r/panacea-core ❯❯❯ panacead gentx --name validator                                                                                             ✘ 1 tags/v1.2.5-internal ✱ ◼
Must specify these options: --node  when --trust-node is false
(⎈ |N/A:N/A)~/r/panacea-core ❯❯❯ panacead gentx --name validator --trust-node                                                                                ✘ 1 tags/v1.2.5-internal ✱ ◼
ERROR: unknown flag: --trust-node

I'm also considering upgrading cosmos/cosmos-sdk directly, without merging this PR.

@cl9200
Copy link
Contributor

cl9200 commented Sep 22, 2020

It seems the cosmos/cosmos-sdk which is used by medibloc/cosmos-sdk has a bug.
When running panacead ..., I got an error when --trust-node is false, but I couldn't specify it due to:

(⎈ |N/A:N/A)~/r/panacea-core ❯❯❯ panacead gentx --name validator                                                                                             ✘ 1 tags/v1.2.5-internal ✱ ◼
Must specify these options: --node  when --trust-node is false
(⎈ |N/A:N/A)~/r/panacea-core ❯❯❯ panacead gentx --name validator --trust-node                                                                                ✘ 1 tags/v1.2.5-internal ✱ ◼
ERROR: unknown flag: --trust-node

I'm also considering upgrading cosmos/cosmos-sdk directly, without merging this PR.

Maybe it's an error caused by viper's IsSet command whose spec is changed.
https://github.com/spf13/viper/releases/tag/v1.6.0

There was a similar error before.
medibloc/cosmos-sdk@a464176

@youngjoon-lee
Copy link
Contributor Author

@cl9200
Yeah.
It's also related to cosmos/cosmos-sdk#6021 fixed in cosmos/cosmos-sdk v0.37.11.

So, let's upgrade the cosmos/cosmos-sdk.

The gaiad is using cosmos/cosmos-sdk v0.37.13. How about following that version?

@cl9200
Copy link
Contributor

cl9200 commented Sep 22, 2020

@youngjoon-lee
I think v0.37.13 would be good.

Copy link
Contributor

@cl9200 cl9200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youngjoon-lee youngjoon-lee merged commit 40dbb0f into master Sep 22, 2020
@youngjoon-lee youngjoon-lee deleted the ft/53/merge-v1.2.5-internal branch September 22, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants