Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #306 #310

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Fixed #306 #310

merged 1 commit into from
Dec 16, 2017

Conversation

Nicklas2751
Copy link
Member

@Nicklas2751 Nicklas2751 commented Dec 16, 2017

Behebt das Problem für #306 mit den falschen Minutenangaben.

Ein merge nach develop ist nicht notwendig da der neue ARD crawler hier bereits richtig agiert.

}
urlSendung = seite1.extract("<a href=\"/tv/", "\"", pos);
if (!urlSendung.isEmpty()) {
urlSendung = "http://www.ardmediathek.de/tv/" + urlSendung;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL Define a constant instead of duplicating this literal "http://www.ardmediathek.de/tv/" 3 times. rule

@alex1702
Copy link
Member

SonarQube analysis reported 1 issue

  • CRITICAL 1 critical

Watch the comments in this conversation to review them.

@alex1702 alex1702 merged commit 55b84ba into master Dec 16, 2017
@alex1702 alex1702 deleted the hotfix/#306 branch December 16, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants