Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/#191 #196

Merged
merged 8 commits into from
Jul 12, 2017
Merged

Hotfix/#191 #196

merged 8 commits into from
Jul 12, 2017

Conversation

pidoubleyou
Copy link
Contributor

Fixes #191

@@ -0,0 +1,52 @@
package mServer.crawler.sender.arte;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Rename this package name to match the regular expression '^[a-z]+(.[a-z][a-z0-9])$'. rule


@Parameterized.Parameters
public static Collection<Object[]> data() {
return Arrays.asList(new Object[][] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Remove this array creation and simply pass the elements. rule

@@ -0,0 +1,16 @@
package mServer.crawler.sender.arte;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Rename this package name to match the regular expression '^[a-z]+(.[a-z][a-z0-9])$'. rule

@@ -0,0 +1,16 @@
package mServer.tool;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Rename this package name to match the regular expression '^[a-z]+(.[a-z][a-z0-9])$'. rule

@@ -0,0 +1,194 @@
package mServer.crawler.sender.arte;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Rename this package name to match the regular expression '^[a-z]+(.[a-z][a-z0-9])$'. rule

@alex1702
Copy link
Member

SonarQube analysis reported 5 issues

  • MINOR 5 minor

Watch the comments in this conversation to review them.

@alex1702 alex1702 merged commit 42eb29e into master Jul 12, 2017
@Nicklas2751
Copy link
Member

Hab es auch zu develop gemerged. Passt nun also.

@Nicklas2751 Nicklas2751 deleted the hotfix/#191 branch July 12, 2017 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants