-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: let user select the directory to save things #680
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.ok_or_else(|| anyhow::anyhow!("failed to get home directory"))? | ||
.join(".screenpipe"); | ||
|
||
// check .screenpipe_dir file whether it exists in default_path, if so, replace default_path | ||
let screenpipe_dir_path = default_path.join(".screenpipe_dir"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall great contribution i wonder if all still work well like including pipes which rely on the https://docs.screenpi.pe/docs/plugins#available-pipes i use the reddit one which rely on the dir, it writes logs of your day using AI and then search for relevant reddit posts based on these logs and generate answer to it can you explain the |
I'm kind of busy in last commit time, the screenpipe-server.rs file which writes media data and db file seems like an external process with tauri, I couldn't find a better way to get the data_dir field from tauri store, so i choose a ungracefully way to add a |
There are also some problem with this pr. what I have found as follow:
I will handle these in another pr and verify pipes in next few days. the ui part may adjust as
|
okay might be related i will test this PR later |
still dont understand what is |
you can do this to display hidden files on macos finder defaults write com.apple.finder AppleShowAllFiles TRUE
killall Finder (PS: finder is such a trash software XD) |
Sorry for my confusing word, let me explain in detail, when user change the $ cat ~/.screenpipe/.screenpipe_dir
# ~/.screenpip1 And then the recorder server start, it will load path from the the filename |
@asd55667 did you look at
if you set the data dir in the sidecar here like other things it would not require the |
yes. in this solution, every operation of write the If I set the data dir in the sidecar here, I think I should sync the value to Once if i access |
hey i don't get what you are saying, just use the |
/claim #669
/closes #669
the summay of changes:
ui
tauri
load_pipe_config
,save_pipe_config
,reset_all_pipes
(unverified)server
I have no clue to check pip-store related changes works, the remains mentioned above all manually checked in my mac-air-m3 device, both dev and build. some missing may occur due to the lack of my knowledge.