Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: include CMake installation in Linux dependencies #505

Merged

Conversation

braxton-mills
Copy link
Contributor


name: pull request
about: submit changes to the project
title: "[pr] "
labels: ''
assignees: ''


description

brief description of the changes in this pr.

Neglecting to install cmake leads to error: failed to run custom build command for 'alsa-sys v0.3.1' when running cargo build --release on linux (sidenote: I'm using WSL2 running Ubuntu 22.04).

  1. reorder apt-get install command for enhanced readability
  2. docs: add missing 'cmake' installation step to apt-get instructions for linux

related issue: none

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

how to test

docs update, no tests to run

checklist

  • i have read the CONTRIBUTING.md file
  • i have added the custom cursor AI prompt to my settings as mentioned in CONTRIBUTING.md and used to write this PR
  • my code follows the project's style guidelines
  • i have performed a self-review of my code
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works
  • all tests pass locally with my changes

additional notes

none

- Moved system library packages (libavformat-dev, libavfilter-dev, libavdevice-dev, libtesseract-dev) to the end of the apt-get install command.
- Placed primary tools (ffmpeg, tesseract-ocr) and build tools (cmake) at the beginning for better logical grouping.
- Improved overall readability and maintainability of the installation instructions.
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 8:07pm

@louis030195
Copy link
Collaborator

@braxton-mills thx!

any chance you can test #477 ? trying to support wayland but need one tester to merge

@louis030195 louis030195 merged commit e89730a into mediar-ai:main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants