Cn OCR support in MacOS #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/tip $100 @QuincySan |
|
@QuincySan: You just got a $100 tip! 👉 Complete your Algora onboarding to collect your payment. |
|
@QuincySan can you fix conflict then i merge? |
louis030195
reviewed
Oct 3, 2024
Cargo.toml
Outdated
| @@ -43,5 +43,8 @@ git = "https://github.com/microsoft/vcpkg" | |||
| rev = "2023.04.15" | |||
| dynamic = true | |||
|
|
|||
| # [dependencies] | |||
| axum = "0.7" # 使用与您项目兼容的版本 | |||
louis030195
reviewed
Oct 3, 2024
screenpipe-vision/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "screenpipe-vision" | |||
| version = { workspace = true } | |||
| version = "0.1.93" | |||
louis030195
reviewed
Oct 3, 2024
screenpipe-vision/Cargo.toml
Outdated
| @@ -38,6 +38,8 @@ screenpipe-integrations = { path = "../screenpipe-integrations" } | |||
| tracing-subscriber = { workspace = true } | |||
| tracing = { workspace = true } | |||
|
|
|||
| axum = "0.7" | |||
|
@louis030195 Appreciate your assistance! I have made the modifications as per your suggestions:
Please review again. If there are any further issues or changes needed, please let me know. Thank you! |
|
@louis030195 Thank you so much for your generous tip and recognition of my work! I truly appreciate it. I want to be transparent - due to regional restrictions, I may face difficulties receiving the payment through Stripe. However, please know that your appreciation itself means a lot to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: pull request
about: submit changes to the project
title: "[PR] Add and optimize Chinese OCR support"
labels: enhancement
assignees: ''
description
This PR adds and optimizes Chinese OCR support in MacOS. These changes aim to expand Screen Pipe’s user base, particularly among Chinese-speaking users.
I used Cursor with o1 and Sonnet 3.5 to assist in generating parts of the code. As I am new to coding, if there are any areas that don’t align with the project’s style, please feel free to provide feedback. I’ve read the CONTRIBUTING.md. :)
Note: Since making these modifications, the original repository has had updates that I am currently unable to resolve or merge on my own. I would appreciate any assistance with handling these differences.
type of change
how to test
To test these changes:
CN_supportcargo build --release --features metalto build the project for macOS.screenshots (if applicable)
checklist
additional notes
mainbranch and myCN_supportbranch due to recent updates to the original repository. I currently lack the ability to resolve these differences and would appreciate any assistance or guidance.