Chore/pimcore template #28
Conversation
| <<: *php-env-vars | ||
| depends_on: [mysql] | ||
|
|
||
| mysql: |
There was a problem hiding this comment.
In the .env.dev file DB_HOST=db is specified. db is also more common used in docker-compose files than mysql (as the name then doesn't specify the type of database used)
| volumes: | ||
| - db:/var/lib/mysql | ||
| environment: | ||
| DB_HOST: "${DB_HOST}" |
There was a problem hiding this comment.
DB_HOST isn't necessary within this container (it doesn't need to know it's own host name)
| - db:/var/lib/mysql | ||
| environment: | ||
| DB_HOST: "${DB_HOST}" | ||
| DB_USER: "${DB_USER}" |
There was a problem hiding this comment.
See https://hub.docker.com/_/mysql section "Environment variables"
It expects environment vars with names "MYSQL_USER" etc, so it creates the right user + database on first boot
| ports: | ||
| - "${MYSQL_PORT}:3306" | ||
|
|
||
| redis-alpine: |
There was a problem hiding this comment.
See magento template, we can use a volume here as well (so cached data remains stored)
| DB_USER: ~ | ||
| DB_PASS: ~ | ||
| DB_NAME: ~ | ||
| MYSQL_ROOT_PASSWORD: ~ |
There was a problem hiding this comment.
MySQL root password shouldn't be necessary within the PHP containers. There is no need (actually discouraged) for your application to connect with the root user
| - elasticsearch:/usr/share/elasticsearch/data | ||
| environment: | ||
| - discovery.type=single-node | ||
| - "ES_JAVA_OPTS=-Xms512m -Xmx512m" |
There was a problem hiding this comment.
Possibly have that 512M memory setting in an .env.dev so it can be configured/overriden locally (if you're on a crappy machine for example)
| [ | ||
| mysqld, | ||
| --character-set-server=utf8mb4, | ||
| --collation-server=utf8mb4_unicode_ci, |
There was a problem hiding this comment.
Is utf8mb4_unicode_520_ci supported (that one is a bit better)
There was a problem hiding this comment.
As best I can tell by looking at mysql 8.x documentation it should be supported yes.
https://dev.mysql.com/doc/mysql-g11n-excerpt/8.0/en/charset-mysql.html
r-vanstraaten
force-pushed
the
chore/pimcore-template
branch
3 times, most recently
from
f57fee5 to
9574639
Compare
| environment: | ||
| MYSQL_USER: "${DB_USER}" | ||
| MYSQL_PASSWORD: "${DB_PASS}" | ||
| MYSQL_DATABASE: "${DB_NAME}" |
There was a problem hiding this comment.
db_1 | 2022-01-06 16:22:16+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.0.27-1debian10 started.
db_1 | 2022-01-06 16:22:16+00:00 [ERROR] [Entrypoint]: Database is uninitialized and password option is not specified
db_1 | You need to specify one of the following:
db_1 | - MYSQL_ROOT_PASSWORD
db_1 | - MYSQL_ALLOW_EMPTY_PASSWORD
db_1 | - MYSQL_RANDOM_ROOT_PASSWORD
There was a problem hiding this comment.
Whoops, removed it here as well apparently when correcting your comment #28 (comment), added it back
r-vanstraaten
force-pushed
the
chore/pimcore-template
branch
from
9574639 to
ed77e9a
Compare
Work in progress