Do not warn on missing phpdocs #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I mean, it's 2021. We have type hints, typed properties, return type declarations and everything. Nobody needs docblocks.
ArjenMiedema
suggested changes
Aug 5, 2021
There was a problem hiding this comment.
@peterjaap I think you added these excludes to the phpcs.xml of this specific project. You should move it into the ruleset in src/MediaCTCommon/ruleset.xml
|
I think it's oke to leave those out. |
leonhelmus
approved these changes
Oct 15, 2021
igorwulff
approved these changes
Oct 15, 2021
|
@igorwulff @leonhelmus the change in this PR is not going to be used in projects that include this repo. This is a change in the project's own phpcs.xml file. Give me a couple of hours to have the fix in the correct place. |
|
@igorwulff @leonhelmus the actual change can be found here: #19. This PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mean, it's 2021. We have type hints, typed properties, return type declarations and everything. Nobody needs docblocks.
This closes #17