Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add practical cosineannealingwarmuprestarts #53

Merged
merged 5 commits into from
Mar 14, 2022

Conversation

HyeonhoonLee
Copy link
Member

현재 pytorch에 구현되어있는 cosineannealingwarmuprestarts는 논문에서 제시한 scheduler를 완벽히 구현하고있지는 못합니다.
LR값이 cosine 주기로 가면서 동시에 convergence도 이루어지는 scheduler 를 추가하였습니다.
사용하실 때는 model_param.scheduler 에 cos_ann_warm_cus 를 입력하면됩니다.

ref: https://gaussian37.github.io/dl-pytorch-lr_scheduler/

@HyeonhoonLee HyeonhoonLee requested a review from ympaik87 March 14, 2022 02:46
@HyeonhoonLee HyeonhoonLee self-assigned this Mar 14, 2022
@HyeonhoonLee HyeonhoonLee changed the base branch from master to develop March 14, 2022 02:46
Copy link
Contributor

@ympaik87 ympaik87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 이정도면 Transformers에 PR날리셔야하는거 아닙니까? ㅎㅎ 인사이트 감사합니다.

@@ -1,5 +1,5 @@
program_param:
wandb_key: b41fa9bf3a38422dafc16e253d84694489607e9f
wandb_key: 6b115fa825114338c0e612d95f732074ccf832c8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wandb_key는 빼고 관리하는게 좋을거같긴합니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제거하시고 머지하세요!

@ympaik87 ympaik87 requested a review from Kingthegarden March 14, 2022 03:25
@ympaik87 ympaik87 added the enhancement New feature or request label Mar 14, 2022
@Kingthegarden
Copy link
Contributor

오 감사합니다. 스케쥴러 실험도 제대로 할 수 있겠네요 ㅎㅎ

@@ -1,5 +1,5 @@
program_param:
wandb_key: b41fa9bf3a38422dafc16e253d84694489607e9f
wandb_key: 6b115fa825114338c0e612d95f732074ccf832c8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제거하시고 머지하세요!

@ympaik87 ympaik87 requested a review from jerife March 14, 2022 04:45
Copy link
Member

@jerife jerife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 확인했으며 수고하셨습니다!

@ympaik87 ympaik87 merged commit 703530c into develop Mar 14, 2022
@ympaik87 ympaik87 deleted the feature/scheduler branch March 14, 2022 06:08
@ympaik87 ympaik87 mentioned this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants