Feature/nerqa saving update #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
오 이런 결점이 있었군용 수정 감사합니다 ! |
Kingthegarden
approved these changes
Mar 9, 2022
Closed
Merged
jerife
reviewed
Mar 10, 2022
| @@ -2,6 +2,8 @@ | |||
| BERT_MODEL_LIST = { | |||
There was a problem hiding this comment.
model path에서 같은 파일이 중복됩니다! 둘중하나 제거해주시면 좋을것 같습니다.
| f"../models/{BERT_MODEL_LIST[cfg.model_param.model_name]}", | ||
| trim_offsets=CFG.model_param.trim_offsets | ||
| ) | ||
| root_save_dir = '../checkpoint' |
There was a problem hiding this comment.
이부분의 경우에는 toknizer를 DebertaV2TokenizerFast 밖에 사용하지 못할 것같은데 config에 맞게 유동적으로 사용할 수 있게 변경해주시면 좋을 것 같습니다!
| @@ -2,6 +2,11 @@ | |||
| BERT_MODEL_LIST = { | |||
There was a problem hiding this comment.
이부분도 "deberta-large"와 "deberta-v3"이부분이 겹칩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NER/QA 모델 저장방식 변경