Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive with instanceof pattern #420

Closed
pdolezal opened this issue Aug 6, 2021 · 1 comment
Closed

False positive with instanceof pattern #420

pdolezal opened this issue Aug 6, 2021 · 1 comment

Comments

@pdolezal
Copy link

pdolezal commented Aug 6, 2021

The instanceof pattern introduced in Java 16 emits code with possibly unnecessary stores. With a code snippets like

if (object instanceof Foo foo) {
    return foo.bar();
}

then the analyzer produces USBR_UNNECESSARY_STORE_BEFORE_RETURN.

@janosvitok
Copy link

janosvitok commented Dec 13, 2024

This is how to reproduce the problem: add the following code to src/samples/java/ex/USBR_Sample.java

   public RuntimeException fpPatternMatching(String num) {
        try {
            int i = Integer.parseInt(num);
        } catch (Exception e) {
            if (e instanceof RuntimeException re) {
                return re; // return typecast exception
	    }
        }
        return null;
    }

Note: This is Java 16 feature, so you have to change build.xml:

		<javac srcdir="${samples.dir}" destdir="${samples.classes.dir}" source="16" target="16" deprecation="${javac.deprecation}" debug="${javac.debug}" includeantruntime="false">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants