$ignore and $comments tags in profiles + optionnal "single profile" to merge + edits to variables in kianiroev #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing obviously wrong ones with NOK)
…lete them before compiling the vehicle_profiles.json file
…eeps them under hand without gobbling too much work on the wican
Quickie : cd .vehicle_profiles/ ; npm run build -- kia/nirosoulkona-ev-abrp.json ; cd ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a single file profile is possible (to make the vehicle_profiles.json shorter and more digest)
For example, let's say I'm working on a copy of an original json file, but the vehicule model is the same as the original, to avoid duplicates and have a tighter file, I can add an option that will glob only one file, instead of /.json
cd .vehicle_profiles/ ; npm run build -- kia/nirosoulkona-ev-abrp.json ; cd ..