-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add renderFooter option in external field #684
feat: add renderFooter option in external field #684
Conversation
@camhammel is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another excellent feature addition, thank you!
Left some comments.
Co-authored-by: Chris Villa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments! Almost perfect now, just spotted one final nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Think I'm actually gonna go ahead and merge this and your other one, so a canary should be released shortly.
Description
Adds a new optional property to external fields,
renderFooter
. This property accepts a function resolving to aReactElement
in place of the default footer, with a prop provided foritems
representing themappedData
.Screenshots
Motivation
We're using the
external
field to allow the user to select an image from a set of images provided by our external service. We'd like to be able to display a "Manage Images" link in the footer to provide the user with a clear path to add/remove any of the image options displayed in the modal.