Add min and max properties to number field #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jperasmus is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
chrisvxd
reviewed
Dec 21, 2023
There was a problem hiding this comment.
This is great, thanks @jperasmus!
If you have time, would you mind adding it to the demo app for the Columns and Flex components?
If not, don't worry. Once this is merged, I'll add it to the docs.
jperasmus
commented
Dec 21, 2023
|
|
||
| ```tsx {5,6,10} copy showLineNumbers | ||
| const config = { | ||
| categories: { | ||
| typography: { | ||
| components: ["HeadingBlock", "ParagraphBlock"], | ||
| label: "Text", | ||
| title: "Text", |
There was a problem hiding this comment.
Just added this extra small fix to the docs that I noticed was wrong.
|
Made the changes as requested and also updated the docs with a basic example showing the 2 new optional fields. |
chrisvxd
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr;
Tiny PR to address #270
details
I wasn't sure if it started to make sense to pull the
NumberFieldinto its own component or add the 2 new props to the existingDefaultField. Went for the pragmatic approach. Happy to split it out as well if needed.