This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Adding protractor options to fix travis failing #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2015
|
NodeJS v4 build still fails: https://travis-ci.org/meanjs/mean/jobs/83819881 |
|
@lirantal Every build is passing, am I not looking in the right place? |
|
@lirantal Here is the e2e results from the Node 4.1.2 build. They seem to be passing. |
|
Indeed they are passing. Not sure what were those errors I saw before when I inspected the v4 output from Travis. I'm not experienced with protractor setup but the changes LGTM. |
|
I'm not experienced either but LGTM |
|
Can we merge this so I can make sure my e2e tests here succeed? #910 |
|
Yes |
lirantal
added a commit
that referenced
this pull request
Oct 9, 2015
Adding protractor options to fix travis failing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #961
