This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
[bug] Solves User model validation issue with tests [fixes #966] #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the issue of the User model's pre('validate') method,
attempting to validate against a password that was not modified.
Adds the this.isModified('password') check to the condition.
mleanos
changed the title
|
Fix for #966 |
|
LGTM and we should quickly push this fix or any alteration for it as this is a bug in |
|
LGTM, we should continue the conversation on #966 to make sure our user saving strategy is well understood. |
|
This will definitely handle the bug. Lets merge it. And then we can continue our discussion about the strategy with the tests. |
lirantal
added a commit
that referenced
this pull request
Oct 10, 2015
[bug] Solves User model validation issue with tests [fixes #966]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue of the User model's
pre('validate')method, attempting to validate against a password that was not modified.Adds the
this.isModified('password')check to the condition.