Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fix issue #424 #425

Merged
merged 1 commit into from
Feb 20, 2015
Merged

Fix issue #424 #425

merged 1 commit into from
Feb 20, 2015

Conversation

vepasto
Copy link
Contributor

@vepasto vepasto commented Feb 19, 2015

Fixes #424.

@ilanbiala
Copy link
Member

What effect does this have?

@vepasto
Copy link
Contributor Author

vepasto commented Feb 19, 2015

The current code does not allow any modules name to end with letter 'c', 'o', 'r' or 'e'.

@ilanbiala
Copy link
Member

If it ends in .routes.js, this shouldn't be a problem, but if someone changes it then there may be issues. Can you link the docs that show this change is the fix? If everything looks good, I'll merge it in.

@ilanbiala
Copy link
Member

LGTM, @lirantal?

@nanuuki
Copy link

nanuuki commented Feb 20, 2015

This probably hasn't been noticed before since the generator will append an s to the end of module names.

@lirantal
Copy link
Member

yes, that looks alright, we can merge.

ilanbiala added a commit that referenced this pull request Feb 20, 2015
@ilanbiala ilanbiala merged commit d1b4bde into meanjs:0.4.0 Feb 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants