Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Revert "Enhancement(core):Relative position attribute added to the header." #1315

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Revert "Enhancement(core):Relative position attribute added to the header." #1315

merged 1 commit into from
Apr 28, 2016

Conversation

trendzetter
Copy link
Contributor

Reverts #1276

@trendzetter
Copy link
Contributor Author

Use standard bootstrap classes instead to fix the issue #1275

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.615% when pulling b633dfb on trendzetter:revert-1276-enhancement-relative-header into f2a6bf9 on meanjs:master.

@ilanbiala
Copy link
Member

@generalgmt @d3dc does this fix work for you?

@trendzetter
Copy link
Contributor Author

@ilanbiala He did confirm: #1275 (comment)

@ilanbiala
Copy link
Member

@generalgmt said navbar-static-top, did he mean navbar-fixed-top?

@trendzetter
Copy link
Contributor Author

trendzetter commented Apr 21, 2016

@ilanbiala navbar-fixed-top is what is used now in meanjs now. What the commit did is override the bootstrap class with some custom css. The proper fix for his issue is replacing navbar-fixed-top with navbar-static-top in his project if this is the preferred behaviour for his application.

@ilanbiala
Copy link
Member

@codydaig @mleanos any issues with this?

@ilanbiala ilanbiala self-assigned this Apr 26, 2016
@ilanbiala ilanbiala added this to the 0.5.0 milestone Apr 26, 2016
@mleanos
Copy link
Member

mleanos commented Apr 27, 2016

I agree with @trendzetter here. We definitely should be using the standard bootstrap class.

I'm fine with this revert. Thanks @trendzetter.

@ilanbiala ilanbiala merged commit e3cd65f into meanjs:master Apr 28, 2016
@trendzetter trendzetter deleted the revert-1276-enhancement-relative-header branch May 3, 2016 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants