This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Fix npm warnings #1080
Merged
Fix npm warnings #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilanbiala Don't forget too squash and fix the commit message. |
ilanbiala
force-pushed
the
npm-warnings
branch
from
df9da79
to
922bfe4
Compare
|
@codydaig rebased, if tests pass you can merge whenever you see this if LGTY. |
|
@ilanbiala I'm not trying to nag, but the commit message still needs too be updated to match the new commit message guidelines. |
ilanbiala
force-pushed
the
npm-warnings
branch
from
922bfe4
to
6088e0f
Compare
|
@codydaig sorry about that. Is the new message better? |
|
@ilanbiala I just realized that you did update the commit message but just used test instead of fix. Sorry :( I just looked at the PR title and forgot they can actually be different. :( LGTM! |
codydaig
added a commit
that referenced
this pull request
Nov 30, 2015
fix(test): Remove npm warnings by testing against Node >=0.12
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1015
Supersedes #1041