Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #254 Update _.server.model.tests.js #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mringer
Copy link

@mringer mringer commented Oct 7, 2016

Fixes MochaJS MochaJS Resolution Method Over Specification in test template code.

@ilanbiala
Copy link
Member

@matthewringer why is the return not necessary anymore?

@codydaig
Copy link
Member

@ilanbiala According to #254, it's returning a promise and calling .done() in which they claim causes issues with Mocha. I have not yet experienced this, but can see what might be happening.

@mringer
Copy link
Author

mringer commented Nov 29, 2016

@ilanbiala as @codydaig mentioned returning the promise and calling .done() which raises an exception with Mocha. There is a more extensive description of the problem in the original issue, and here is an instance of the same issue from Mocha's repo.

Let me know if you have any other questions.

@ilanbiala
Copy link
Member

@codydaig LGTY?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants