Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 0.3.0, dropping support for Python <= 3.7 #31

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

schivmeister
Copy link
Contributor

@schivmeister schivmeister commented Oct 20, 2023

Python 3.7 and earlier reached EOL earlier this year, and many
tools/libraries have stopped supporting those runtimes. Continuing to
support an old runtime will be near impossible due to dependency hell.
It is therefore only wise to follow suit.

Dependencies have been upgraded, but no other changes were required in
this project; API and ABI compatibility is maintained in this version.
Most of the changes were in the key dependency eds4jinja2, so all
benefits have been derived transitively.

Like eds4jinja2, Python versions 3.8 and 3.11 are supported and tested
for. Unlike eds4jinja2, support for Windows and Mac OS cannot be
tested due to unavailability of or problems with docker{-compose} on
those platforms. Cross-platform commitment for this project therefore
remains informal.

Additionally, license has been changed from GPL to Apache.

References:

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da037a8) 94.91% compared to head (d37ad79) 91.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   94.91%   91.52%   -3.39%     
==========================================
  Files           6        6              
  Lines          59       59              
==========================================
- Hits           56       54       -2     
- Misses          3        5       +2     
Flag Coverage Δ
unittests 91.52% <100.00%> (-3.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
fingerprint/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@costezki costezki removed the request for review from CaptainOfHacks October 30, 2023 16:25
@costezki costezki marked this pull request as ready for review October 30, 2023 16:26
@schivmeister schivmeister marked this pull request as draft October 30, 2023 17:03
@schivmeister schivmeister force-pushed the feature/MWB-193 branch 3 times, most recently from 4a49276 to 7f0cad3 Compare October 30, 2023 17:47
@schivmeister schivmeister marked this pull request as ready for review October 30, 2023 17:49
Python 3.7 and earlier reached EOL earlier this year, and many
tools/libraries have stopped supporting those runtimes. Continuing to
support an old runtime will be near impossible due to dependency hell.
It is therefore only wise to follow suit.

Dependencies have been upgraded, but no other changes were required in
this project; API and ABI compatibility is maintained in this version.
Most of the changes were in the key dependency `eds4jinja2`, so all
benefits have been derived transitively.

Like `eds4jinja2`, Python versions 3.8 and 3.11 are supported and tested
for. Unlike `eds4jinja2`, support for Windows and Mac OS cannot be
tested due to unavailability of or problems with `docker{-compose}` on
those platforms. Cross-platform commitment for this project therefore
remains informal.

Additionally, license has been changed from GPL to Apache.

References:
- actions/runner#904
- actions/runner-images#17 (comment)
@schivmeister schivmeister merged commit 52e91b7 into master Oct 30, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants