Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #4592 Users on low resolution can have inputs error off screen but no indication - Adds generic error #4692

Conversation

onemustpersist
Copy link

What type of PR is this?

  • bug
  • ux

What this PR does / why we need it:

UX improvement on low resolutions when adding a new user. Calls to alert.error() with translatable error message to inform the user a field that an off screen is not filled in correctly. Does not check resolution size so would happen to all users.

Which issue(s) this PR fixes:

Fixes #4592

Low resolution users not being made aware that a form submission has failed when adding a new user.
User experience improvement

Special notes for your reviewer:

View port size: 1333 × 730
Ties into existing i18n and alert.error

Testing

Tried in Firefox 133.0 (64 bit)
View port size: 1333 × 730

task py:test

1199 passed, 26 skipped, 182 warnings in 662.56s (0:11:02)

task ui:test

Test Files  8 passed (8)
Tests  72 passed (72)
 Start at  00:12:05
 Duration  3.53s (transform 505ms, setup 0ms, collect 2.29s, tests 200ms)

popup
popup2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant