-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Markdown paragraph spacing issue in recipe notes #4664
Conversation
Hey there! Changes look good in the screenshots, but I think something's wrong with the branch/PR. I'm only seeing changes to the poetry lock file, rather than the frontend changes. Can you double check the branch? |
Yes, I look into that. Thank you |
It looks like you changed a bunch of the dev container config and added NPM. It doesn't look like this PR needs any dependency changes, so please remove changes to those files from this PR. If I'm reading this correctly, the only changes should be those made in It may be easier to start fresh with a new branch off of |
Let me know if I did it correctly. I moved all the changes I made and only updated the |
I'm still seeing changes to 11 files: https://github.com/mealie-recipes/mealie/pull/4664/files |
Yes, I am not sure how to remove those files. I tried your recommendation of working off another branch, but when I committed my changes it still shows the 10 files from the prior commit. I searched to see if there was a way to undo a commit and none of the answers were helpful. It seems like maybe closing this PR and reopening another might be better? Please let me know. |
@michael-genson I opened a draft pull request #4687. I had accidentally closed this PR attempting to update the files. Let me know upon your review if the other PR is good. Thanks for your patience while I tried to figure this out :) |
No worries! That one looks much better :) I should have time to review early next week (out of town this weekend). Feel free to take it out of draft when it's ready! |
Sounds good! I have marked it for review. |
What type of PR is this?
What this PR does / why we need it:
This PR addresses an issue where single-line breaks in recipe notes caused incorrect paragraph spacing. The following changes were made:
preprocessMarkdown
function toRecipeNotes.vue
to convert single line breaks into double line breaks for proper Markdown rendering.SafeMarkdown
usage inRecipeNotes.vue
to preprocess text before rendering.These changes ensure that paragraphs are spaced correctly when rendering recipe notes.
Before:
After:
Which issue(s) this PR fixes:
Fixes #2854
Fixes #2846
Testing
Since this was a UI improvement, I just observed the changes