feat: Add 'No Shopping Lists Found' message #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
requested changes
Dec 2, 2024
|
Ahh sorry, didn't realize it was handled automatically! Fixed it. |
michael-genson
requested changes
Dec 3, 2024
frontend/lang/messages/en-US.json
Outdated
| @@ -872,7 +872,8 @@ | |||
| "you-are-offline-description": "Not all features are available while offline. You can still add, modify, and remove items, but you will not be able to sync your changes to the server until you are back online.", | |||
| "are-you-sure-you-want-to-check-all-items": "Are you sure you want to check all items?", | |||
| "are-you-sure-you-want-to-uncheck-all-items": "Are you sure you want to uncheck all items?", | |||
| "are-you-sure-you-want-to-delete-checked-items": "Are you sure you want to delete all checked items?" | |||
| "are-you-sure-you-want-to-delete-checked-items": "Are you sure you want to delete all checked items?", | |||
| "no-shopping-list-found": "No Shopping Lists Found." | |||
There was a problem hiding this comment.
I think this looks better without the period, since it's standalone text. Also want to make sure the key matches the text
Suggested change
| "no-shopping-list-found": "No Shopping Lists Found." | |
| "no-shopping-lists-found": "No Shopping Lists Found" |
| @@ -21,6 +21,12 @@ | |||
| <BaseButton create @click="createDialog = true" /> | |||
| </v-container> | |||
|
|
|||
| <v-container v-if="shoppingListChoices.length === 0"> | |||
| <BasePageTitle> | |||
| <template #title>{{ $t('shopping-list.no-shopping-list-found') }}</template> | |||
There was a problem hiding this comment.
Suggested change
| <template #title>{{ $t('shopping-list.no-shopping-list-found') }}</template> | |
| <template #title>{{ $t('shopping-list.no-shopping-lists-found') }}</template> |
| @@ -21,6 +21,12 @@ | |||
| <BaseButton create @click="createDialog = true" /> | |||
| </v-container> | |||
|
|
|||
| <v-container v-if="shoppingListChoices.length === 0"> | |||
There was a problem hiding this comment.
This is a nitpick, no need to change, but for the sake of learning FYI this also works:
<v-container v-if="!shoppingListChoices.length">It's preference, but this way is more typical
There was a problem hiding this comment.
No, that's great feedback, I will change it. I'm new to Vue so every bit of "for the sake of learning" is helpful, thank you.
…he add-to-list dialog box.
|
I think I got all the feedback, but let me know if I missed anything! |
michael-genson
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
Currently, if there are no shopping lists, the Shopping Lists page just shows a blank screen. This adds a message where the shopping lists would show if they existed that says "No Shopping Lists Found".
Before:
After:
Testing
Since this was a UI improvement, I just observed the changes visually.