feat: OIDC: add the ability to override the requested scopes #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
We craft the scopes to request from a user's IdP depending on if the group variables are configured or not. If they are configured, then we request
openid profile email groupsscope, and if not, thenopenid profile email. Some IdPs, like Entra ID, can be configured to always send agroupsclaim, but doesn't require or even accept agroupsscope. So this PR adds the ability to override our scope creation logic and let the user specify exactly which scopes to request from the IdP.Which issue(s) this PR fixes:
Fixes #4528
Testing
Manually tested with Azure (Entra ID)