feat: Improve Recipe Imports with Cleaner #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
We have a pretty robust recipe data cleaner for migrations, but we aren't actually using it for our scraping. This refactors the scraping/cleaning process a bit to make sure the cleaner actually runs on all imported recipes.
This also fixes a bug with OpenAI scraping which would fail on the
ld+jsonimport. We now includeld+jsondata along with the HTML text.Which issue(s) this PR fixes:
(REQUIRED)
Fixes issue raised in #4490
Special notes for your reviewer:
(fill-in or delete this section)
I feel like we used to run all recipes through the cleaner, I'm not sure if/when/how that changed. But it works now!
Testing
(fill-in or delete this section)
Manually with a bunch of local data