Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds descriptions to feature checks and add them to logs #4504

Conversation

cmintey
Copy link
Contributor

@cmintey cmintey commented Nov 3, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

Adds some additional logging around our application features on startup. This is similar to the app checks in the admin UI, but I think its nice to log them as well and the descriptions can be helpful in debugging. We could also show these descriptions in the app checks on the settings page, but we'd need to consider translations.

Also, instead of excluding secrets from the dump, this PR will instead mask the secrets with "*****" or if the secret is None, will show it as null. This again will help with debugging to show when values are set without logging secrets.

image

Which issue(s) this PR fixes:

Not an issue, but a discussion: #3334 (comment)
This doesn't directly fix it, but hopefully will help in debugging

@cmintey
Copy link
Contributor Author

cmintey commented Nov 3, 2024

Hold on this, thinking of adding something else here
Implemented the changes with tests

@cmintey cmintey mentioned this pull request Nov 8, 2024
6 tasks
@michael-genson michael-genson enabled auto-merge (squash) November 8, 2024 05:29
@michael-genson michael-genson merged commit 8ce6f90 into mealie-recipes:mealie-next Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants