feat: adds descriptions to feature checks and add them to logs #4504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds some additional logging around our application features on startup. This is similar to the app checks in the admin UI, but I think its nice to log them as well and the descriptions can be helpful in debugging. We could also show these descriptions in the app checks on the settings page, but we'd need to consider translations.
Also, instead of excluding secrets from the dump, this PR will instead mask the secrets with
"*****"
or if the secret is None, will show it asnull
. This again will help with debugging to show when values are set without logging secrets.Which issue(s) this PR fixes:
Not an issue, but a discussion: #3334 (comment)
This doesn't directly fix it, but hopefully will help in debugging