fix: round ingredient amounts when not using fractions #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Ingredient amounts were not rounded when Fractions were turned of for that specific unit. This leads to unnecessairy precision described in #4465. This rounds the number to three significant digits.
Resulting in the following output for the 400 / 160 scaled from 6 to 7 in the issue linked above.
Happy to tune the precision if somebody sees a case where this would not be enough. Couldn't think of one.
Which issue(s) this PR fixes:
Special notes for your reviewer:
I had to do some back and forth casting to between Numbers and Strings to:
If there is a better method please let me know.
Testing
Manual testing with the example described in #4465