feat: implement the possibility to add tls #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wim de Groot <[email protected]>
feat: enable support for tls
|
@michael-genson, you seem to contribute a lot to this project. I'am not able to find anything about a process on asking for a review. Do you know how this works? |
|
Hey there! All of the maintainers contribute to Mealie in their spare time, so we don't really have a review schedule. We will get to it eventually, promise! |
michael-genson
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Looks good, thanks for this! Could you add the new variables to the docs?
docs/docs/documentation/getting-started/installation/backend-config.md.
You can put it between Webworker and LDAP (unless you think it's better somewhere else). And maybe add a small blurb that this is only for serving Mealie without a webserver/reverse proxy.
Signed-off-by: Wim de Groot <[email protected]>
michael-genson
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Mealie needs to have the option to use a TLS certificate, for the following cases:
Which issue(s) this PR fixes:
Fixes: #2294
Special notes for your reviewer:
I am not sure if the naming of the properties is in line with the project, I would like feedback on that.
Testing
I've tested this change by deploying the app to my homelab. Since the features of uvicorn are mostly used here I am not sure if there are more unit tests needed.